Skip to content

VCST-4182: Order Document Count Validation#477

Merged
OlegoO merged 9 commits intodevfrom
feat/VCST-4182
Dec 26, 2025
Merged

VCST-4182: Order Document Count Validation#477
OlegoO merged 9 commits intodevfrom
feat/VCST-4182

Conversation

@OlegoO
Copy link
Contributor

@OlegoO OlegoO commented Dec 16, 2025

Description

feat: Order Document Count Validation. Default 20.
feat: Enable Order Validation.

References

QA-test:

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-4182

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.Orders_3.864.0-pr-477-4a44.zip


Note

Validation and limits

  • Enable Order.Validation.Enable by default and validate orders in CustomerOrderService.SaveChangesAsync and payment post-process (throws on errors)
  • Add Order.MaxOrderDocumentCount (default 20) and new OrderDocumentCountValidator to cap total child documents via IOperation tree
  • Introduce CustomerOrderValidator (setting-aware) and PaymentInValidator; register all validators in DI

Settings, docs, and i18n

  • Add MaxOrderDocumentCount and update ModuleConstants (defaults, AllSettings); remove settings dependency from payment service method-level validation
  • Substantially expand README (architecture, features, configuration incl. validation settings)
  • Add localization entries for the new setting across languages

Tests

  • New unit tests for CustomerOrderValidator and OrderDocumentCountValidator; update service tests to inject validators and settings mocks

Written by Cursor Bugbot for commit 8a0ff00. This will update automatically on new commits. Configure here.

feat: Order Document Count Validation. Default 20.
feat: Enable Order Validation.
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 9.148
Timestamp: 16-12-2025T18:47:00

Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.648
Timestamp: 16-12-2025T19:15:43

Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.378
Timestamp: 16-12-2025T19:25:33

Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.476
Timestamp: 16-12-2025T19:35:37

Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.798
Timestamp: 16-12-2025T19:45:15

@sonarqubecloud
Copy link

Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.016
Timestamp: 17-12-2025T08:22:14

@OlegoO OlegoO merged commit 4619d54 into dev Dec 26, 2025
2 of 3 checks passed
@OlegoO OlegoO deleted the feat/VCST-4182 branch December 26, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants